cloud-fan commented on a change in pull request #35355:
URL: https://github.com/apache/spark/pull/35355#discussion_r803285366
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -978,37 +978,41 @@ object JdbcUtils extends Logging with SQLConfHelper {
options: JDBCOptions,
namespace: String,
comment: String): Unit = {
+ val statement = conn.createStatement
+ try {
+ statement.setQueryTimeout(options.queryTimeout)
+ val dialect = JdbcDialects.get(options.url)
+ dialect.createSchema(statement, namespace, comment)
+ } finally {
+ statement.close()
+ }
+ }
+
+ def namespaceExists(conn: Connection, options: JDBCOptions, namespace:
String): Boolean = {
Review comment:
since we are touching this file, can we rename `namespace` to `schema`
for all these methods in this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
