cloud-fan commented on a change in pull request #35355:
URL: https://github.com/apache/spark/pull/35355#discussion_r803285764
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
##########
@@ -229,6 +229,44 @@ abstract class JdbcDialect extends Serializable with
Logging{
}
}
+ /**
+ * Create schema with an optional comment. Empty string means no comment.
+ */
+ def createSchema(statement: Statement, schema: String, comment: String):
Unit = {
+ val schemaCommentQuery = if (comment.nonEmpty) {
+ getSchemaCommentQuery(schema, comment)
Review comment:
let's leave a comment: "We generate comment query here so that it can
fail earlier without creating the schema."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
