cloud-fan commented on a change in pull request #35569:
URL: https://github.com/apache/spark/pull/35569#discussion_r810889474
##########
File path:
core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala
##########
@@ -305,4 +304,11 @@ class HadoopMapReduceCommitProtocol(
logWarning(s"Exception while aborting
${taskContext.getTaskAttemptID}", e)
}
}
+
+ private def cleanStagingDir(jobContext: JobContext): Unit = {
+ val fs = stagingDir.getFileSystem(jobContext.getConfiguration)
+ if (fs.exists(stagingDir)) {
Review comment:
This needs two RPC calls to remove the directory now, isn't it also a
performance issue?
BTW, does `FileSystem` provide an API with "delete if exists" semantic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
