AngersZhuuuu commented on a change in pull request #35569:
URL: https://github.com/apache/spark/pull/35569#discussion_r810972568
##########
File path:
core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala
##########
@@ -305,4 +304,11 @@ class HadoopMapReduceCommitProtocol(
logWarning(s"Exception while aborting
${taskContext.getTaskAttemptID}", e)
}
}
+
+ private def cleanStagingDir(jobContext: JobContext): Unit = {
+ val fs = stagingDir.getFileSystem(jobContext.getConfiguration)
+ if (fs.exists(stagingDir)) {
Review comment:
> One thing about this method is it's used when creating the path,
notifying the FileSystem to delete when FileSystem is closed. A little
different from the current use of `fs.delete(stagingDir)`.
I mean we can do like `SaveAsHiveFile`, mkdir first and let it delete when
system exit. Since `deleteOnExit` will check file exit when deleting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
