symious commented on a change in pull request #35569:
URL: https://github.com/apache/spark/pull/35569#discussion_r810980252
##########
File path:
core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala
##########
@@ -305,4 +304,11 @@ class HadoopMapReduceCommitProtocol(
logWarning(s"Exception while aborting
${taskContext.getTaskAttemptID}", e)
}
}
+
+ private def cleanStagingDir(jobContext: JobContext): Unit = {
+ val fs = stagingDir.getFileSystem(jobContext.getConfiguration)
+ if (fs.exists(stagingDir)) {
Review comment:
I think the stagingDir is not created`HadoopMapReduceCommitProtocol` or
its subclass, it's just noting the directory and the actual `OutputCommiter`
will do the creation.
Unless we are asking `HadoopMapReduceCommitProtocol` and
`SQLHadoopMapReduceCommitProtocol` to create the stagingDir at the following
situation.
```
* The staging directory of this write job. Spark uses it to deal with
files with absolute output
* path, or writing data into partitioned directory with
dynamicPartitionOverwrite=true.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
