attilapiros commented on a change in pull request #35619:
URL: https://github.com/apache/spark/pull/35619#discussion_r812641442
##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -3221,11 +3221,12 @@ private[spark] object Utils extends Logging {
* Return the median number of a long array
*
* @param sizes
+ * @param alreadySorted
* @return
*/
- def median(sizes: Array[Long]): Long = {
+ def median(sizes: Array[Long], alreadySorted: Boolean = false): Long = {
Review comment:
What about always assuming the `sizes` are sorted (mentioning this in
the description and reflecting in the parameter name ie. `sortedSizes` or in
the name of the method..)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
