wankunde commented on a change in pull request #35619:
URL: https://github.com/apache/spark/pull/35619#discussion_r813581591
##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -3221,11 +3221,12 @@ private[spark] object Utils extends Logging {
* Return the median number of a long array
*
* @param sizes
+ * @param alreadySorted
* @return
*/
- def median(sizes: Array[Long]): Long = {
+ def median(sizes: Array[Long], alreadySorted: Boolean = false): Long = {
Review comment:
Hi, @attilapiros , in my opinion, `median` method should support
unsorted input array and it has already been used in some other classes. But if
we change the parameter name to `sortedSizes`, that will be a little confusing?
WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
