wankunde commented on a change in pull request #35619:
URL: https://github.com/apache/spark/pull/35619#discussion_r814647556
##########
File path: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala
##########
@@ -265,7 +265,7 @@ private[spark] object HighlyCompressedMapStatus {
val threshold =
if (accurateBlockSkewedFactor > 0) {
val sortedSizes = uncompressedSizes.sorted
- val medianSize: Long = Utils.median(sortedSizes)
+ val medianSize: Long = Utils.median(sortedSizes, true)
Review comment:
Hi, @zhengruifeng Originally I wrote the median function code here, but
@JoshRosen suggested extracting the common code into a util function
https://github.com/apache/spark/pull/34234#discussion_r731369282 .
Either changing the median method or copying some code here all makes sense
to me.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
