Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/6019#discussion_r30261470
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/Identifiable.scala
---
@@ -19,15 +19,24 @@ package org.apache.spark.ml.util
import java.util.UUID
+
/**
- * Object with a unique id.
+ * Trait for an object with an immutable unique ID that identifies itself
and its derivatives.
*/
-private[ml] trait Identifiable extends Serializable {
+trait Identifiable {
+
+ /**
+ * An immutable unique ID for the object and its derivatives.
--- End diff --
How user-facing is this? Should we provide more info/promises about how it
is used, or should we wait until that is clearer to us?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
