Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/6019#issuecomment-101771182
@mengxr A bunch of small comments, but other than those, it looks good. At
some point, it might be nice to add a test suite helper method which does
standard checks to make sure models are handled correctly. E.g.: take
(Estimator, Model, paramMap passed to fit()), and check UID, parent, and
parameter values copied to the model. I'll make a JIRA for that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
