Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6019#discussion_r30299831
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/Identifiable.scala 
---
    @@ -19,15 +19,24 @@ package org.apache.spark.ml.util
     
     import java.util.UUID
     
    +
     /**
    - * Object with a unique id.
    + * Trait for an object with an immutable unique ID that identifies itself 
and its derivatives.
      */
    -private[ml] trait Identifiable extends Serializable {
    +trait Identifiable {
    +
    +  /**
    +   * An immutable unique ID for the object and its derivatives.
    --- End diff --
    
    Good question! I don't think the `Identifiable` interface is user facing, 
not developer facing either. The only useful function to developers is the 
`randomUID` under `object Identifiable`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to