srowen commented on a change in pull request #35763:
URL: https://github.com/apache/spark/pull/35763#discussion_r821651852
##########
File path: dev/check-license
##########
@@ -44,7 +44,7 @@ acquire_rat_jar () {
# We failed to download
rm "$JAR"
printf "Our attempt to download rat locally to ${JAR} failed. Please
install rat manually.\n"
- exit -1
+ exit 255
Review comment:
Can we get an explanation for a few of the changes that occur
frequently? like is this equivalent to returning -1?
##########
File path: dev/create-release/release-build.sh
##########
@@ -181,7 +181,7 @@ BASE_PROFILES="-Pmesos -Pyarn -Pkubernetes"
PUBLISH_SCALA_2_13=1
SCALA_2_13_PROFILES="-Pscala-2.13"
-if [[ $SPARK_VERSION < "3.2" ]]; then
+if [ "$(echo $SPARK_VERSION | awk -F "." '{if ($1 <= 3 && $2 < 2) print $1}')"
]; then
Review comment:
Or this too, was it nonstandard bash?
##########
File path: dev/create-release/release-build.sh
##########
@@ -53,7 +53,7 @@ if [ $# -eq 0 ]; then
exit_with_usage
fi
-if [[ $@ == *"help"* ]]; then
+if [[ "$*" == *"help"* ]]; then
Review comment:
Likewise what is the difference here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
