stczwd commented on a change in pull request #35763:
URL: https://github.com/apache/spark/pull/35763#discussion_r822255664
##########
File path: dev/check-license
##########
@@ -44,7 +44,7 @@ acquire_rat_jar () {
# We failed to download
rm "$JAR"
printf "Our attempt to download rat locally to ${JAR} failed. Please
install rat manually.\n"
- exit -1
+ exit 255
Review comment:
BTW，`shellcheck` support exclude check rules, thus if we support `exit
-1`, we can excude SC2242 in GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
