huaxingao commented on a change in pull request #35768:
URL: https://github.com/apache/spark/pull/35768#discussion_r825264667
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/filter/Or.java
##########
@@ -20,20 +20,18 @@
import org.apache.spark.annotation.Evolving;
/**
- * A filter that evaluates to {@code true} iff at least one of {@code left} or
{@code right}
+ * A predicate that evaluates to {@code true} if at least one of {@code left}
or {@code right}
* evaluates to {@code true}.
*
* @since 3.3.0
*/
@Evolving
-public final class Or extends BinaryFilter {
+public final class Or extends Predicate {
- public Or(Filter left, Filter right) {
- super(left, right);
+ public Or(Predicate left, Predicate right) {
+ super("AND", new Predicate[]{left, right});
Review comment:
`"OR"`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
