huaxingao commented on a change in pull request #35768:
URL: https://github.com/apache/spark/pull/35768#discussion_r825519822
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
##########
@@ -94,6 +96,74 @@ object JDBCRDD extends Logging {
new StructType(columns.map(name => fieldMap(name)))
}
+ def translateFilterV1ToV2(f: Filter): Option[Predicate] = {
Review comment:
Instead of converting each of the V1 Filters here, can we define
```
private[sql] def toV2: Predicate
```
in V1 `Filter`? In this way I can reuse the V1 to V2 code in file source. I
will start migrating V1 Filter to V2 Filter in file source after this PR is
merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
