huaxingao commented on a change in pull request #35768:
URL: https://github.com/apache/spark/pull/35768#discussion_r825519866
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
##########
@@ -239,10 +331,10 @@ private[jdbc] class JDBCRDD(
/**
* `filters`, but as a WHERE clause suitable for injection into a SQL query.
*/
- private val filterWhereClause: String =
- filters
- .flatMap(JDBCRDD.compileFilter(_, JdbcDialects.get(url)))
- .map(p => s"($p)").mkString(" AND ")
+ private val filterWhereClause: String = {
+ val dialect = JdbcDialects.get(url)
+ predicates.flatMap(dialect.compileExpression(_)).map(p =>
s"($p)").mkString(" AND ")
Review comment:
Since now `compileExpression` is used instead of `compileFilter` to
construct the sql String for filters, then `compileFilter` is only used by V1
`JDBCRelation.unhandledFilters`. We probably should simplify and rename
`compileFilter`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
