cloud-fan commented on a change in pull request #35768:
URL: https://github.com/apache/spark/pull/35768#discussion_r825604859
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java
##########
@@ -103,8 +119,26 @@ protected String visitIsNotNull(String v) {
return v + " IS NOT NULL";
}
+ protected String visitStringPredicate(String name, String l, String r) {
+ String value = r.replaceAll("'", "");
+ switch (name) {
+ case "STARTS_WITH":
+ return l + " LIKE '" + value + "%'";
+ case "ENDS_WITH":
+ return l + " LIKE '%" + value + "'";
+ default: // "CONTAINS"
Review comment:
Let's match `CONTAINS` explicitly and the default case should throw
exception, so that we won't make mistake when we add new string predicates
later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
