cloud-fan commented on a change in pull request #35768:
URL: https://github.com/apache/spark/pull/35768#discussion_r825955352
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/filter/AlwaysTrue.java
##########
@@ -17,34 +17,32 @@
package org.apache.spark.sql.connector.expressions.filter;
-import java.util.Objects;
-
import org.apache.spark.annotation.Evolving;
-import org.apache.spark.sql.connector.expressions.NamedReference;
+import org.apache.spark.sql.connector.expressions.Literal;
+import org.apache.spark.sql.types.DataType;
+import org.apache.spark.sql.types.DataTypes;
/**
- * A filter that always evaluates to {@code true}.
+ * A predicate that always evaluates to {@code true}.
*
* @since 3.3.0
*/
@Evolving
-public final class AlwaysTrue extends Filter {
+public class AlwaysTrue extends Predicate implements Literal<Boolean> {
- @Override
- public boolean equals(Object o) {
- if (this == o) return true;
- if (o == null || getClass() != o.getClass()) return false;
- return true;
+ private DataType dataType = DataTypes.BooleanType;
+
+ public AlwaysTrue() {
+ super("ALWAYS_TRUE", new Predicate[]{});
}
- @Override
- public int hashCode() {
- return Objects.hash();
+ public Boolean value() {
+ return true;
}
- @Override
- public String toString() { return "TRUE"; }
Review comment:
Can we keep it as TRUE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
