cloud-fan commented on a change in pull request #35768:
URL: https://github.com/apache/spark/pull/35768#discussion_r825969806
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/sources/filters.scala
##########
@@ -64,6 +67,11 @@ sealed abstract class Filter {
private[sql] def containsNestedColumn: Boolean = {
this.v2references.exists(_.length > 1)
}
+
+ /**
+ * Converts V1 filter to V2 filter
+ */
+ def toV2: Option[Predicate]
Review comment:
when can it return None? I thought v2 can fully cover v1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
