cloud-fan commented on a change in pull request #35768:
URL: https://github.com/apache/spark/pull/35768#discussion_r825970658
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/sources/filters.scala
##########
@@ -78,6 +86,8 @@ sealed abstract class Filter {
@Stable
case class EqualTo(attribute: String, value: Any) extends Filter {
override def references: Array[String] = Array(attribute) ++
findReferences(value)
+ override def toV2: Option[Predicate] = Some(new Predicate("=",
+ Array(FieldReference(attribute), LiteralValue(value,
Literal(value).dataType))))
Review comment:
There is another difference: v1 uses external value like `String`, while
v2 uses internal value like `UTF8String`. We need to do translation properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
