beliefer commented on a change in pull request #35768:
URL: https://github.com/apache/spark/pull/35768#discussion_r825998336
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
##########
@@ -237,11 +244,7 @@ abstract class JdbcDialect extends Serializable with
Logging{
@Since("3.3.0")
def compileExpression(expr: Expression): Option[String] = {
val jdbcSQLBuilder = new JDBCSQLBuilder()
- try {
- Some(jdbcSQLBuilder.build(expr))
- } catch {
- case _: IllegalArgumentException => None
Review comment:
```
val e = intercept[IllegalArgumentException] {
doCompileFilter(EqualTo("col0.nested", 3))
}.getMessage
assert(e.contains("Filter push down does not support nested column:
col0.nested"))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
