cloud-fan commented on a change in pull request #35768:
URL: https://github.com/apache/spark/pull/35768#discussion_r825987551
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2Suite.scala
##########
@@ -155,35 +155,39 @@ class DataSourceV2Suite extends QueryTest with
SharedSparkSession with AdaptiveS
checkAnswer(q1, (0 until 10).map(i => Row(-i)))
if (cls == classOf[AdvancedDataSourceV2WithV2Filter]) {
val batch = getBatchWithV2Filter(q1)
- assert(batch.filters.isEmpty)
+ assert(batch.predicates.isEmpty)
assert(batch.requiredSchema.fieldNames === Seq("j"))
} else {
val batch = getJavaBatchWithV2Filter(q1)
- assert(batch.filters.isEmpty)
+ assert(batch.predicates.isEmpty)
assert(batch.requiredSchema.fieldNames === Seq("j"))
}
val q2 = df.filter(Symbol("i") > 3)
checkAnswer(q2, (4 until 10).map(i => Row(i, -i)))
if (cls == classOf[AdvancedDataSourceV2WithV2Filter]) {
val batch = getBatchWithV2Filter(q2)
- assert(batch.filters.flatMap(_.references.map(_.describe)).toSet ==
Set("i"))
Review comment:
Seems hard, we probably need to move `reference` to the v2 `Expression`
interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
