cloud-fan commented on a change in pull request #35352:
URL: https://github.com/apache/spark/pull/35352#discussion_r826542860
##########
File path:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
##########
@@ -999,13 +1000,22 @@ public static UTF8String concatWs(UTF8String separator,
UTF8String... inputs) {
}
public UTF8String[] split(UTF8String pattern, int limit) {
+ return split(pattern, limit, false);
+ }
+
+ public UTF8String[] split(UTF8String pattern, int limit, boolean ifQuote) {
Review comment:
I think internal consistency is more important than being compatible
with other systems. It's super weird that `split` and `split_part` functions
interpret the delimiter parameter differently.
##########
File path:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
##########
@@ -999,13 +1000,22 @@ public static UTF8String concatWs(UTF8String separator,
UTF8String... inputs) {
}
public UTF8String[] split(UTF8String pattern, int limit) {
+ return split(pattern, limit, false);
+ }
+
+ public UTF8String[] split(UTF8String pattern, int limit, boolean ifQuote) {
Review comment:
cc @srielau
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
