cloud-fan commented on a change in pull request #35352:
URL: https://github.com/apache/spark/pull/35352#discussion_r828591498
##########
File path:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
##########
@@ -1013,6 +1014,21 @@ public static UTF8String concatWs(UTF8String separator,
UTF8String... inputs) {
return res;
}
+ public UTF8String[] split_delimiter(UTF8String delimiter, int limit) {
Review comment:
We can have a private method `UTF8String[] split(String delimiter, int
limit)`, and 2 public methods: `UTF8String[] split(UTF8String pattern, int
limit)`, `UTF8String[] splitSQL(UTF8String delimiter, int limit)`. The 2 public
methods just call the private method with different delimiter string.
FYI we have also `substring` and `substringSQL` in this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
