cloud-fan commented on a change in pull request #35352:
URL: https://github.com/apache/spark/pull/35352#discussion_r828109474
##########
File path:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
##########
@@ -999,13 +1000,22 @@ public static UTF8String concatWs(UTF8String separator,
UTF8String... inputs) {
}
public UTF8String[] split(UTF8String pattern, int limit) {
+ return split(pattern, limit, false);
+ }
+
+ public UTF8String[] split(UTF8String pattern, int limit, boolean ifQuote) {
Review comment:
Code reuse is not a key factor here. The problem is, our users don't
know about our code details. They see two similar functions `split` and
`split_part`, and I believe they will be very surprised if these two functions
define the delimiter parameter differently.
For example, it's reasonable if the users assume `split(str, del)[0]` will
return the same result of `split_part(str, del, 1)` (Spark array index is
0-based).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
