cloud-fan commented on a change in pull request #35768:
URL: https://github.com/apache/spark/pull/35768#discussion_r829094135
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java
##########
@@ -190,6 +113,30 @@ public GeneralScalarExpression(String name, Expression[]
children) {
public String name() { return name; }
public Expression[] children() { return children; }
+ @Override
+ public NamedReference[] references() {
+ return Arrays.stream(children()).map(e -> {
+ if (e instanceof NamedReference) {
Review comment:
why do we need this check? Following the catalyst `Expression`, we just
need to combine the references from children and deduplicate them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
