cloud-fan commented on a change in pull request #35768:
URL: https://github.com/apache/spark/pull/35768#discussion_r828044702
##########
File path:
sql/core/src/test/java/test/org/apache/spark/sql/connector/JavaAdvancedDataSourceV2WithV2Filter.java
##########
@@ -96,30 +104,33 @@ public Scan build() {
@Override
public Batch toBatch() {
- return new AdvancedBatchWithV2Filter(requiredSchema, filters);
+ return new AdvancedBatchWithV2Filter(requiredSchema, predicates);
}
}
public static class AdvancedBatchWithV2Filter implements Batch {
// Exposed for testing.
public StructType requiredSchema;
- public Filter[] filters;
+ public Predicate[] predicates;
- AdvancedBatchWithV2Filter(StructType requiredSchema, Filter[] filters) {
+ AdvancedBatchWithV2Filter(StructType requiredSchema, Predicate[]
predicates) {
this.requiredSchema = requiredSchema;
- this.filters = filters;
+ this.predicates = predicates;
}
@Override
public InputPartition[] planInputPartitions() {
List<InputPartition> res = new ArrayList<>();
Integer lowerBound = null;
- for (Filter filter : filters) {
- if (filter instanceof GreaterThan) {
- GreaterThan f = (GreaterThan) filter;
- if ("i".equals(f.column().describe()) && f.value().value()
instanceof Integer) {
- lowerBound = (Integer) f.value().value();
+ for (Predicate predicate : predicates) {
+ if (predicate.name().equals(">")) {
+ assert(predicate.children()[0] instanceof FieldReference);
+ FieldReference column = (FieldReference) predicate.children()[0];
+ assert(predicate.children()[1] instanceof LiteralValue);
+ Literal value = (LiteralValue) predicate.children()[1];
Review comment:
```suggestion
Literal value = (Literal) predicate.children()[1];
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
