cloud-fan commented on a change in pull request #35768:
URL: https://github.com/apache/spark/pull/35768#discussion_r828043589
##########
File path:
sql/core/src/test/java/test/org/apache/spark/sql/connector/JavaAdvancedDataSourceV2WithV2Filter.java
##########
@@ -61,32 +63,38 @@ public StructType readSchema() {
}
@Override
- public Filter[] pushFilters(Filter[] filters) {
- Filter[] supported = Arrays.stream(filters).filter(f -> {
- if (f instanceof GreaterThan) {
- GreaterThan gt = (GreaterThan) f;
- return gt.column().describe().equals("i") && gt.value().value()
instanceof Integer;
+ public Predicate[] pushPredicates(Predicate[] predicates) {
+ Predicate[] supported = Arrays.stream(predicates).filter(f -> {
+ if (f.name().equals(">")) {
+ assert(f.children()[0] instanceof FieldReference);
+ FieldReference column = (FieldReference) f.children()[0];
+ assert(f.children()[1] instanceof LiteralValue);
+ Literal value = (LiteralValue) f.children()[1];
Review comment:
```suggestion
Literal value = (Literal) f.children()[1];
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
