Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/6019#discussion_r30299828
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -379,7 +427,6 @@ trait Params extends Identifiable with Serializable {
* @param value the default value
*/
protected final def setDefault[T](param: Param[T], value: T): this.type
= {
- shouldOwn(param)
--- End diff --
This causes some racing condition. Because not all members are initialized
before `setDefault` is called. `shouldOwn` checks `params`, which is a lazy
val. If `params` is initialized before some params, it would contains `null`. I
didn't figure out a good solution. Given that this is not called by users, I
removed this check and left a note on `params`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
