cloud-fan commented on code in PR #36625:
URL: https://github.com/apache/spark/pull/36625#discussion_r884891864
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala:
##########
@@ -753,7 +760,10 @@ private[hive] class HiveClientImpl(
assert(s.values.forall(_.nonEmpty), s"partition spec '$s' is invalid")
s
}
- val parts = shim.getPartitions(client, hiveTable,
partSpec.asJava).map(fromHivePartition)
+ val absoluteUri =
shim.getDataLocation(hiveTable).map(stringToURI).filter(!_.isAbsolute)
+ .map(_ =>
stringToURI(client.getDatabase(hiveTable.getDbName).getLocationUri))
+ val parts = shim.getPartitions(client, hiveTable, partSpec.asJava)
+ .map(fromHivePartition(_, absoluteUri))
Review Comment:
does this mean we always calculate the absoluteUri even if the partition uri
is absolute?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
