cloud-fan commented on code in PR #36625:
URL: https://github.com/apache/spark/pull/36625#discussion_r883337878
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala:
##########
@@ -1432,4 +1434,24 @@ object HiveExternalCatalog {
isHiveCompatibleDataType(m.keyType) &&
isHiveCompatibleDataType(m.valueType)
case _ => true
}
+
+ /**
+ * Rewrite uri to absolute location. For example:
+ * uri: /user/hive/warehouse/test_table
+ * parentUri: viewfs://clusterA/user/hive/warehouse/
+ * The result is: viewfs://clusterA/user/hive/warehouse/test_table
+ */
+ private[spark] def toAbsoluteURI(uri: URI, parentUri: Option[URI]): URI = {
Review Comment:
I think the name `parentUri` is a bit misleading. It's more like an
`absoluteUri` which we need to inherit its schema, host, port, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
