cloud-fan commented on code in PR #36625:
URL: https://github.com/apache/spark/pull/36625#discussion_r883336067
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala:
##########
@@ -753,7 +762,13 @@ private[hive] class HiveClientImpl(
assert(s.values.forall(_.nonEmpty), s"partition spec '$s' is invalid")
s
}
- val parts = shim.getPartitions(client, hiveTable,
partSpec.asJava).map(fromHivePartition)
+ val parentUri = if (hiveTable.getDataLocation.toUri.isAbsolute) {
+ None
+ } else {
+ convertHiveTableToCatalogTable(hiveTable).storage.locationUri
Review Comment:
shoudn't this be
`CatalogUtils.stringToURI(client.getDatabase(h.getDbName).getLocationUri)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
