cloud-fan commented on code in PR #36698:
URL: https://github.com/apache/spark/pull/36698#discussion_r885230648
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala:
##########
@@ -521,6 +651,7 @@ trait DivModLike extends BinaryArithmetic {
} else {
${eval1.code}
$checkIntegralDivideOverflow
+ $checkOverflow
Review Comment:
this should be put after `${ev.value} = $operation;`, otherwise what value
is picked to check overflow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
