cloud-fan commented on code in PR #36698:
URL: https://github.com/apache/spark/pull/36698#discussion_r885231906
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala:
##########
@@ -373,11 +457,24 @@ case class Subtract(
override def decimalMethod: String = "$minus"
+ override def decimalType(p1: Int, s1: Int, p2: Int, s2: Int): DecimalType = {
+ val resultScale = max(s1, s2)
+ if (allowPrecisionLoss) {
Review Comment:
can we write the code in this way?
```
val resultPrecision = ...
val resultScale = ...
if (allowPrecisionLoss) {
DecimalType.adjustPrecisionScale(resultPrecision, resultScale)
} else {
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
