cloud-fan commented on code in PR #36698:
URL: https://github.com/apache/spark/pull/36698#discussion_r885232378
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala:
##########
@@ -575,7 +707,31 @@ case class Divide(
override def symbol: String = "/"
override def decimalMethod: String = "$div"
+ override def decimalType(p1: Int, s1: Int, p2: Int, s2: Int): DecimalType = {
+ if (allowPrecisionLoss) {
+ // Precision: p1 - s1 + s2 + max(6, s1 + p2 + 1)
+ // Scale: max(6, s1 + p2 + 1)
+ val intDig = p1 - s1 + s2
+ val scale = max(DecimalType.MINIMUM_ADJUSTED_SCALE, s1 + p2 + 1)
+ val prec = intDig + scale
+ DecimalType.adjustPrecisionScale(prec, scale)
+ } else {
+ var intDig = min(DecimalType.MAX_SCALE, p1 - s1 + s2)
+ var decDig = min(DecimalType.MAX_SCALE, max(6, s1 + p2 + 1))
+ val diff = (intDig + decDig) - DecimalType.MAX_SCALE
+ if (diff > 0) {
+ decDig -= diff / 2 + 1
+ intDig = DecimalType.MAX_SCALE - decDig
+ }
+ DecimalType.bounded(intDig + decDig, decDig)
+ }
+ }
+
private lazy val div: (Any, Any) => Any = dataType match {
+ case decimalType: DecimalType => (l, r) => {
+ val value =
decimalType.fractional.asInstanceOf[Fractional[Any]].div(l, r)
Review Comment:
nit: indentation is wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
