cloud-fan commented on code in PR #36698:
URL: https://github.com/apache/spark/pull/36698#discussion_r885417861
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala:
##########
@@ -490,10 +621,26 @@ trait DivModLike extends BinaryArithmetic {
s"${eval2.value} == 0"
}
val javaType = CodeGenerator.javaType(dataType)
- val operation = if (operandsDataType.isInstanceOf[DecimalType]) {
-
decimalToDataTypeCodeGen(s"${eval1.value}.$decimalMethod(${eval2.value})")
+ val checkOverflow = if (operandsDataType.isInstanceOf[DecimalType]) {
+ val decimal = super.dataType.asInstanceOf[DecimalType]
+ val errorContextCode = if (nullOnOverflow) {
Review Comment:
We can move this outside of the `if-else`, so that we can remove
https://github.com/apache/spark/pull/36698/files?file-filters%5B%5D=.scala&show-viewed-files=true#diff-4e0c12ae8844d177eeef91dd2739e42ed819d435a2b336f068a5431be3b02652R645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
