cloud-fan commented on code in PR #36698:
URL: https://github.com/apache/spark/pull/36698#discussion_r885415814
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala:
##########
@@ -490,10 +621,26 @@ trait DivModLike extends BinaryArithmetic {
s"${eval2.value} == 0"
}
val javaType = CodeGenerator.javaType(dataType)
- val operation = if (operandsDataType.isInstanceOf[DecimalType]) {
-
decimalToDataTypeCodeGen(s"${eval1.value}.$decimalMethod(${eval2.value})")
+ val checkOverflow = if (operandsDataType.isInstanceOf[DecimalType]) {
Review Comment:
this name is confusing. This includes the operation and overflow checking.
Maybe the previous `operation` is still a good name here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
