MaxGekk commented on code in PR #36857:
URL: https://github.com/apache/spark/pull/36857#discussion_r897724324
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala:
##########
@@ -1015,6 +1014,11 @@ case class Cast(
} catch {
case _: NumberFormatException => null
}
+ case x: DayTimeIntervalType =>
+ buildCast[Long](_, dt => changePrecision(dayTimeIntervalToDecimal(dt,
x.endField), target))
+ case x: YearMonthIntervalType =>
+ buildCast[Int](_, ym =>
+ changePrecision(Decimal(yearMonthIntervalToInt(ym, x.startField,
x.endField)), target))
Review Comment:
As we did before, we don't consider non-ANSI mode for ANSI intervals. So, we
are in ANSI mode always for ANSI intervals.
> what if the decimal precision is too small, e.g. decimal(1, 0)
I think `changePrecision()` should output an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
