MaxGekk commented on code in PR #36857:
URL: https://github.com/apache/spark/pull/36857#discussion_r898174044


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala:
##########
@@ -1015,6 +1014,11 @@ case class Cast(
       } catch {
         case _: NumberFormatException => null
       }
+    case x: DayTimeIntervalType =>
+      buildCast[Long](_, dt => changePrecision(dayTimeIntervalToDecimal(dt, 
x.endField), target))
+    case x: YearMonthIntervalType =>
+      buildCast[Int](_, ym =>
+        changePrecision(Decimal(yearMonthIntervalToInt(ym, x.startField, 
x.endField)), target))

Review Comment:
   > PS: I loathe that cannot-change-decimal-precision error. In most cases we 
should just call it an overflow.
   
   I plan to do that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to