MaxGekk commented on code in PR #36857:
URL: https://github.com/apache/spark/pull/36857#discussion_r898168474
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala:
##########
@@ -1015,6 +1014,11 @@ case class Cast(
} catch {
case _: NumberFormatException => null
}
+ case x: DayTimeIntervalType =>
+ buildCast[Long](_, dt => changePrecision(dayTimeIntervalToDecimal(dt,
x.endField), target))
Review Comment:
> Does changePrecision take a bool flag like nullOnOverflow?
No, it checks the SQL config actually, passed to the `Cast` expression:
```scala
private[this] def changePrecision(value: Decimal, decimalType:
DecimalType): Decimal = {
if (value.changePrecision(decimalType.precision, decimalType.scale)) {
value
} else {
if (!ansiEnabled) {
null
} else {
throw QueryExecutionErrors.cannotChangeDecimalPrecisionError(
value, decimalType.precision, decimalType.scale, queryContext)
}
}
}
```
Probably, it makes sense to incapsulate the logic:
https://github.com/apache/spark/blob/a4f96afdc147bfee3e0f195b7bcf3dfa882ad511/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala#L993-L1000
Also cc @gengliangwang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
