singhpk234 commented on code in PR #37202:
URL: https://github.com/apache/spark/pull/37202#discussion_r922693898
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGenerationSuite.scala:
##########
@@ -568,7 +568,6 @@ class CodeGenerationSuite extends SparkFunSuite with
ExpressionEvalHelper {
assert(refTerm.contains("scala.math.LowPriorityOrderingImplicits$$anon$"))
}
- // TODO (SPARK-35579): Fix this bug in janino and upgrade janino in Spark.
Review Comment:
@srowen I think, when this bug was discovered we were at janino v3.1.4, ref
[cloudfan's branch](https://github.com/cloud-fan/spark/tree/janino) for adding
the UT in ignore mode, since the problem was only in 3.1.x branch of janino, we
reverted back janino to 3.0.16 (3.0.x seems be deprecated as well
[ref](https://github.com/janino-compiler/janino/pull/148#issuecomment-1085006136)).
The [PR](https://github.com/apache/spark/pull/33302) to revert janino upgrade
(3.1.4 -> 3.0.16), also enabled the UT since 3.0.x didn't had the issue.
Now when we bump back 3.1.7 i.e use janino 3.1.x and this test passes
implies 3.1.7 has this bug fix, and kind of validates version bump is safe.
Thoughts ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
