rednaxelafx commented on PR #37202: URL: https://github.com/apache/spark/pull/37202#issuecomment-1189757594
Post-hoc question: what's the main driving factor to upgrade from Janino 3.0.16 to the Janino 3.1.x line? Is it compilation speed driven, or generated bytecode size driven, or other misc goodies like the `getBytecodes` feature mentioned in this PR's description? If the main driving factor(s) are mostly cosmetic, then IMHO the risk/benefit ratio of the upgrading doesn't seem favorable yet at this point. cc @maropu asking for advice, are you confident that the stack map computation logic in the 3.1.x line are now stable enough for prime time? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
