rednaxelafx commented on PR #37202: URL: https://github.com/apache/spark/pull/37202#issuecomment-1190554647
Thank you very much for the reply! Janino 3.0.x is indeed deprecated, and the 3.0.16 release was a special case specifically done for Spark after some bugfixes were made on top of 3.0.15 from Spark contributors. That said, given previous attempts to upgrade to Janino 3.1.x line in Spark all hit various issues that ended up getting reverted, I don't feel particularly comfortable with the upgrade. The bug mentioned above https://github.com/janino-compiler/janino/issues/165 can be easily fixed on top of 3.0.16 too, although we already know there's unlikely going to be any new 3.0.x releases... There are many options here. I'm okay with this PR as-is, but in case we hit bugs with this version of Janino we may still want to roll back to 3.0.16 and try other options, e.g. forking or patching on top of 3.0.16. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
