cloud-fan commented on code in PR #36918:
URL: https://github.com/apache/spark/pull/36918#discussion_r925292702
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/BatchScanExec.scala:
##########
@@ -56,16 +58,26 @@ case class BatchScanExec(
@transient private lazy val filteredPartitions: Seq[Seq[InputPartition]] = {
val dataSourceFilters = runtimeFilters.flatMap {
- case DynamicPruningExpression(e) =>
DataSourceStrategy.translateRuntimeFilter(e)
+ case DynamicPruningExpression(e) =>
+ scan match {
+ case _: SupportsRuntimeFiltering =>
+ DataSourceStrategy.translateRuntimeFilter(e)
+ case _: SupportsRuntimeV2Filtering =>
Review Comment:
shall we make `SupportsRuntimeV2Filtering` have higher priority over
`SupportsRuntimeFiltering`? Also we need to document the behavior if a source
implements both of them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
