cloud-fan commented on code in PR #36918:
URL: https://github.com/apache/spark/pull/36918#discussion_r925294799
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala:
##########
@@ -582,6 +583,28 @@ private[sql] object DataSourceV2Strategy {
throw new IllegalStateException("Failed to rebuild Expression for
filter: " + predicate))
}
}
+
+ /**
+ * Translates a runtime filter into a data source v2 Predicate.
+ *
+ * Runtime filters usually contain a subquery that must be evaluated before
the translation.
+ * If the underlying subquery hasn't completed yet, this method will throw
an exception.
+ */
+ protected[sql] def translateRuntimeFilterV2(expr: Expression):
Option[Predicate] = expr match {
+ case in @ InSubqueryExec(PushableColumnAndNestedColumn(name), _, _, _, _,
_) =>
+ val values = in.values().getOrElse {
+ throw new IllegalStateException(s"Can't translate $in to v2 Predicate,
no subquery result")
+ }
+ val literals = values.map { value =>
+ val literal = Literal(value)
+ LiteralValue(literal.value, literal.dataType)
Review Comment:
We don't need to infer the data type by creating a catalyst `Literal`. The
type must be `in.child.dataType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
