cloud-fan commented on code in PR #36918:
URL: https://github.com/apache/spark/pull/36918#discussion_r925296507


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/PartitionPruning.scala:
##########
@@ -85,6 +85,13 @@ object PartitionPruning extends Rule[LogicalPlan] with 
PredicateHelper with Join
         } else {
           None
         }
+      case (resExp, r @ DataSourceV2ScanRelation(_, scan: 
SupportsRuntimeV2Filtering, _, _, _)) =>

Review Comment:
   I'm not very sure, is it possible to make `SupportsRuntimeFiltering` extends 
`SupportsRuntimeV2Filtering`? And inside `SupportsRuntimeFiltering` we 
translate v2 filter to v1. Then Spark only needs to deal with 
`SupportsRuntimeV2Filtering`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to