Ngone51 commented on code in PR #37268:
URL: https://github.com/apache/spark/pull/37268#discussion_r934220131
##########
core/src/main/scala/org/apache/spark/resource/ResourceProfile.scala:
##########
@@ -253,6 +265,32 @@ class ResourceProfile(
}
}
+/**
+ * Resource profile which only contains task resources, used for stage level
task schedule when
+ * dynamic allocation is disabled, tasks will be scheduled to executors with
default resource
+ * profile based on task resources described by this task resource profile.
+ *
+ * @param taskResources Resource requests for tasks. Mapped from the resource
+ * name (e.g., cores, memory, CPU) to its specific
request.
+ */
+@Evolving
+@Since("3.4.0")
+class TaskResourceProfile(override val taskResources: Map[String,
TaskResourceRequest])
+ extends ResourceProfile(Map.empty, taskResources) {
+
+ /**
+ * Target executor's resource profile id, used for schedule.
+ */
+ override def targetExecutorRpId: Int =
ResourceProfile.DEFAULT_RESOURCE_PROFILE_ID
Review Comment:
I think we should override `_id` instead so that
`ResourceProfile.getNextProfileId` doesn't increase for task resource profile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
