AngersZhuuuu commented on code in PR #37436:
URL: https://github.com/apache/spark/pull/37436#discussion_r941255226
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/util/SQLOpenHashSet.scala:
##########
@@ -85,12 +85,13 @@ object SQLOpenHashSet {
index: String,
hashSet: String,
handleNotNull: (String, String) => String,
- handleNull: String): String = {
+ handleNull: String,
+ nullConditions: Seq[String] = Seq.empty): String = {
if (arrayContainsNull) {
if (setContainsNull) {
s"""
|if ($array.isNullAt($index)) {
- | if (!$hashSet.containsNull()) {
+ | if (!$hashSet.containsNull()${nullConditions.map(" &&" +
_).mkString("")}) {
Review Comment:
Caused by `ArrayType`'s `containsNull` just means it can contains null, not
really mean in this array contains a null, we should pass another flag to this
function to mark array 2 contain a null element.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
