AngersZhuuuu commented on code in PR #37436:
URL: https://github.com/apache/spark/pull/37436#discussion_r943147717
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala:
##########
@@ -4155,9 +4155,11 @@ case class ArrayIntersect(left: Expression, right:
Expression) extends ArrayBina
right.dataType.asInstanceOf[ArrayType].containsNull,
array1, i, hashSetResult, withArray1NaNCheckCodeGenerator,
s"""
- |$nullElementIndex = $size;
- |$size++;
- |$builder.$$plus$$eq($nullValueHolder);
+ |if ($hashSet.containsNull()) {
Review Comment:
No, and add same UT of `ArrayExcept`, should we remove the added test case
about `ArrayExcept`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
