cloud-fan commented on code in PR #37436:
URL: https://github.com/apache/spark/pull/37436#discussion_r942042163
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala:
##########
@@ -4158,7 +4158,8 @@ case class ArrayIntersect(left: Expression, right:
Expression) extends ArrayBina
|$nullElementIndex = $size;
|$size++;
|$builder.$$plus$$eq($nullValueHolder);
- """.stripMargin)
+ """.stripMargin,
+ Some(s"$hashSet.containsNull()"))
Review Comment:
The interpreted code path is:
```
val withArray1NullCheckFunc =
SQLOpenHashSet.withNullCheckFunc(elementType, hsResult,
(value: Any) => withArray1NaNCheckFunc(value),
() =>
if (hs.containsNull()) {
arrayBuffer += null
}
)
```
Can we follow it in the codegen path? e.g. `handleNull` should check `if
(hashSet.containsNull())`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
